fix(http-client): replay the request body on redirects without throwing - #4136
Open
SulimanAbdulrazzaq wants to merge 1 commit into
Open
SulimanAbdulrazzaq wants to merge 1 commit into
SulimanAbdulrazzaq wants to merge 1 commit into
Conversation
`buildRedirectRequest()` passes the cloned body stream to `new Request()` without `duplex: 'half'`, which Node rejects. Every redirect that keeps the body (307/308, and 301/302 for methods other than POST) made `sendRequest()` throw a `TypeError` instead of following the redirect. Closes apify#4133
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildRedirectRequest()passed the cloned request body, aReadableStream, tonew Request()withoutduplex: 'half', which Node rejects. So every redirect that keeps the body (307/308, and 301/302 for methods other than POST) madesendRequest()throwTypeError: RequestInit: duplex option is required when sending a body.instead of following it.HttpCrawlerrequests with apayloadfailed the same way, because the crawler sends the payload as a stream.The redirected request now sets
duplex: 'half', the same optionHttpCrawleralready sets on its initial request. The replay itself was already correct, becauseinitialRequestis cloned before the first send.Closes #4133