Pipe: Fix leader cache updates for multi-device redirects - #18689
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18689 +/- ##
=========================================
Coverage 44.36% 44.36%
Complexity 712 712
=========================================
Files 5483 5483
Lines 394207 394227 +20
Branches 51177 51183 +6
=========================================
+ Hits 174882 174909 +27
+ Misses 219325 219318 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jt2594838
approved these changes
Sep 22, 2026
…-30-pipe-leader-cache # Conflicts: # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/thrift/IoTDBDataNodeReceiver.java # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/util/cacher/LeaderCacheUtils.java # iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/sink/util/cacher/LeaderCacheUtilsTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Multi-device insert-node responses can carry leader redirections in per-device sub-statuses. The pipe sender previously handled only a top-level redirect for direct insert-node transfers, so its leader cache could remain stale and repeatedly route writes to the wrong receiver node.
This change:
Validation
master.mvn -pl iotdb-core/datanode spotless:check -DskipTests -Dcheckstyle.skip=truegit diff --checkThe 40 GB cluster workload has not been rerun locally. A targeted test rerun after switching to
masterwas blocked by unrelated stale cross-module generated artifacts/dependencies in the local checkout; none of the reported compilation errors referenced the files changed here.