Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport commit
9be80ead1dc51e1100ebc4add54be055afc2e888todev/1.3.This updates
PathPatternNodeto cache compiled non-trivial wildcard patterns and clear that cache when children are deleted or the node is cleared.PathPatternUtilreuses the compilation helper, and regression tests cover add, replacement, delete, and clear lifecycles.The cherry-pick required adapting the upstream generic type parameter to the
dev/1.3VSerializername; no target-branch behavior was discarded.Testing
mvn spotless:apply -pl iotdb-core/node-commons— passedmvn test -pl iotdb-core/node-commons -Dtest=PathPatternNodeTest -DfailIfNoTests=false— compilation, Checkstyle, and Spotless passed; Surefire could not start its fork because the local JVM failed to allocate memory (Windows paging-file error), so assertions did not run.Key changed/added classes
PathPatternNodePathPatternUtilPathPatternNodeTest