Skip to content

[To dev/1.3] Fix PathPatternNode wildcard cache lifecycle (#18672) - #18688

Open
Caideyipi wants to merge 1 commit into
apache:dev/1.3from
Caideyipi:cp-9be80ead-dev-1.3
Open

Caideyipi wants to merge 1 commit into
apache:dev/1.3from
Caideyipi:cp-9be80ead-dev-1.3

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

Backport commit 9be80ead1dc51e1100ebc4add54be055afc2e888 to dev/1.3.

This updates PathPatternNode to cache compiled non-trivial wildcard patterns and clear that cache when children are deleted or the node is cleared. PathPatternUtil reuses the compilation helper, and regression tests cover add, replacement, delete, and clear lifecycles.

The cherry-pick required adapting the upstream generic type parameter to the dev/1.3 VSerializer name; no target-branch behavior was discarded.

Testing

  • mvn spotless:apply -pl iotdb-core/node-commons — passed
  • mvn test -pl iotdb-core/node-commons -Dtest=PathPatternNodeTest -DfailIfNoTests=false — compilation, Checkstyle, and Spotless passed; Surefire could not start its fork because the local JVM failed to allocate memory (Windows paging-file error), so assertions did not run.
Key changed/added classes
  • PathPatternNode
  • PathPatternUtil
  • PathPatternNodeTest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant