refactor(serde): move DataFile JSON handling from REST to core - #974
Open
kamcheungting-db wants to merge 3 commits into
Open
kamcheungting-db wants to merge 3 commits into
kamcheungting-db wants to merge 3 commits into
Conversation
This was referenced Sep 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
DataFileJSON serialization and deserialization from the REST catalog into core serde.This is a mechanical move. It does not intentionally change the JSON format or validation behavior. REST keeps forwarding overloads, so existing REST callers continue to use the same API.
Why
Core
FileScanTaskserde needs to read and write data files without depending on the REST catalog.Before:
iceberg::rest::DataFileFromJson(json, specs, schema);After:
iceberg::DataFileFromJson(json, specs, schema);Stack
This is 1 of 4:
DataFileserde into coreDataFileJSON (fix(serde): make DataFile JSON compatible with Java Iceberg #975)FileScanTaskJSON serde (feat(serde): support standalone FileScanTask JSON in core #939)Each PR targets
main; later PRs contain the commits from earlier PRs.Testing
json_serde_testandrest_catalog_teston the complete stack.