Conversation
FrankChen021
left a comment
There was a problem hiding this comment.
🟢 Approval recommended
The root POM now exposes concrete Maven Central coordinates early enough for Maven to resolve the Apache parent, and the shared worker preflights that resolution with a clear three-attempt retry before starting each job. I also inspected all in-repository callers of the reusable worker and the surrounding root-POM build/profile configuration; no changed behavior introduced an actionable risk.
Reviewed 2 of 2 changed files.
Validation: narrow git diff --check against the supplied merge-base and PR head passed. No builds, tests, installs, or formatters were run.
This is an automated review by Codex GPT-5.6-Luna(max)
FrankChen021
left a comment
There was a problem hiding this comment.
🟢 Approval recommended
No actionable issues found in this review. The reusable worker now resolves the root Apache parent before any job-specific work and retries transient Maven failures, the root POM uses concrete Maven Central coordinates for both dependency and plugin resolution, and the listener test matches the current TaskRunnerListener API. The previously requested explanation for the standalone preflight step is present in the current head.
Reviewed 3 of 3 changed files.
Validation: git merge-tree --write-tree master HEAD completed without conflicts, and git diff --check passed. No builds, tests, installs, or formatters were run.
This is an automated review by Codex GPT-5.6 Luna(Max)
|
@gitedmond please rebase your branch to the latest master to resolve the conflict |
d419928 to
d9bb6d0
Compare
|
@FrankChen021 rebased |
Fixes #20436.
Description
Two master jobs aborted while resolving the root
org.apache:apacheparent POM, before their assigned Maven work began. Maven reported a repository URL of${repoOrgUrl}literally when the parent was unavailable locally.Use concrete Maven Central coordinates in the root POM's repository and plugin repository declarations. The
repoOrg*properties had no other uses and were removed. The shared CI worker now runs a root-only Mavenvalidateafter Java setup, retrying up to three times with-Uand a 10-second delay before the main script. A persistent failure still fails the job on the third attempt.Validation
mvn -B -U -N validate -Pskip-static-checks -Dweb.console.skip=truepassed using an initially empty local Maven repository and downloadedorg.apache:apache:pom:40.actionlintpassed for the edited workflow. A shell harness verified success on attempt three after two failures and exit 1 after three failures.git diff --check: passed.The OpenRewrite and QTest jobs require PR CI to verify in their hosted environment.
This PR has: