Fuzz: Display roundtrip - #2528
Merged
Merged
Conversation
LucaCappelletti94
added this pull request to stack #2529
September 19, 2026 05:47
7 tasks
LucaCappelletti94
marked this pull request as ready for review
September 19, 2026 06:04
LucaCappelletti94
force-pushed
the
fuzz-roundtrip-harness
branch
from
September 21, 2026 19:13
939f006 to
6c5cbe3
Compare
Contributor
Author
|
@alamb any notes on this one? |
LucaCappelletti94
force-pushed
the
fuzz-roundtrip-harness
branch
from
September 21, 2026 20:24
6c5cbe3 to
a30e374
Compare
alamb
approved these changes
Sep 21, 2026
| use sqlparser::parser::Parser; | ||
|
|
||
| fuzz_target!(|sql: &str| { | ||
| let dialects: [(&str, &dyn Dialect); 14] = [ |
Contributor
There was a problem hiding this comment.
it might be nice to use a pre-existing dialect enum for this (or add it somewhere) so that newly added dialects automatically get coverage
Contributor
Author
There was a problem hiding this comment.
For now, I made sure to extend the harnesses and include all of the dialects we are currently cover. I have spent a little while thinking about what could be the cleanest variant going forward but I am not too sure for now. Almost surely, it will be some code we move from the test suites into the lib under a test cfg.
LucaCappelletti94
force-pushed
the
fuzz-roundtrip-harness
branch
2 times, most recently
from
September 22, 2026 08:15
38705fa to
a30e374
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 3 of #2519, stacked on #2527.
This PR adds the display roundtrip harness for all dialects.
A first 60 seconds run already finds
SELECT [a]]b]inMsSqlDialectrendering asSELECT [a]b], which fails to re-parse. That is the bug class of #2409, already being fixed in #2418, so this harness should help guide that PR..clusterfuzzlite/build.shiterates overcargo fuzz list, so the new target is picked up by the CI builds with no workflow change.