Skip to content

Added derive for arbitrary - #2193

Draft
LucaCappelletti94 wants to merge 1 commit into
apache:mainfrom
LucaCappelletti94:arbitrary
Draft

LucaCappelletti94 wants to merge 1 commit into
apache:mainfrom
LucaCappelletti94:arbitrary

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

Adds Arbitrary derives to all AST structs and enums for property-based testing and fuzzing.

Changes

  • Added arbitrary as optional dependency with feature gating
  • Derived Arbitrary on all public AST types in ast
  • Added Arbitrary to core types (Token, Span, Location, etc.)
  • Excluded display helpers and iterators

Note: BigDecimal (used in Value::Number) lacks Arbitrary support. PR submitted: akubera/bigdecimal-rs#163

@github-actions

github-actions Bot commented Apr 6, 2026

Copy link
Copy Markdown

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Apr 6, 2026
@github-actions github-actions Bot closed this Apr 13, 2026
@LucaCappelletti94

Copy link
Copy Markdown
Contributor Author

This type of GitHub Actions is not positive IMHO. This PR is blocked by another PR uphill, and closing it does not make the problem go away.

@LucaCappelletti94

Copy link
Copy Markdown
Contributor Author

Will need rebasing, but finally akubera/bigdecimal-rs#163 has been merged and hopefully a new version of bigdecimal will be published soonish.

@github-actions github-actions Bot removed the Stale label Sep 23, 2026
@LucaCappelletti94 LucaCappelletti94 added experimental Trying out a new concept or idea that might never land fuzzer A bug found by the fuzzer labels Sep 28, 2026
LucaCappelletti94 added a commit to LucaCappelletti94/sqlparser-rs that referenced this pull request Oct 2, 2026
@codecov-commenter

codecov-commenter commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.15%. Comparing base (c70b5b1) to head (82d0288).

Files with missing lines Patch % Lines
src/ast/value.rs 83.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2193   +/-   ##
=======================================
  Coverage   81.14%   81.15%           
=======================================
  Files          42       42           
  Lines       33739    33751   +12     
  Branches    33739    33751   +12     
=======================================
+ Hits        27379    27389   +10     
  Misses       2797     2797           
- Partials     3563     3565    +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

experimental Trying out a new concept or idea that might never land fuzzer A bug found by the fuzzer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants