floor the options column at the Options header width - #443
Open
rootvector2 wants to merge 1 commit into
Open
rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
appendOptions sized the column only from the option entries, so a column narrower than the Options header made the header gap negative and createPadding allocated a negative-length array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
appendOptionssizes the options column only from the rendered option entries and never from the header row, so once every option is narrower than theOptionsheader the gap it computes for the header line,max - maxSince - HEADER_OPTIONS.length() + leftPad, is negative andcreatePaddingrunsnew char[-3]. WithsetShowSince(true)that makesprintHelpthrowNegativeArraySizeExceptionfor something as ordinary as an app whose flags are-hand-v. Found while fuzzing the help output across option widths and pad settings.determineMaxSinceLengthalready floors the since column at the width of theSinceheader; the option column just needs the same floor, somaxnow starts there whenshowSinceis set. Keeping the bound next to the arithmetic that uses it leaves everycreatePaddingargument in the method non-negative, and output is unchanged for anyOptionswhose column was already that wide.mvn; that'smvnon the command line by itself.