Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Only a minor wording nit remains; no blocking issues were identified.
Pull request overview
Fixes project-scoped security group rule targeting by applying correct ownership and source-group resolution.
Changes:
- Adds ownership scope to authorization requests.
- Restricts source-group lookup to the target project.
- Adds unit and acceptance test coverage.
File summaries
| File | Summary | Review notes |
|---|---|---|
cloudstack/resource_cloudstack_security_group_rule.go |
Implements scoped authorization and source-group resolution. | Nit: change “more then one” to “more than one” at line 291. |
cloudstack/resource_cloudstack_security_group_rule_test.go |
Adds ownership and project-scoped acceptance tests. | No blocking issues. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| } | ||
|
|
||
| if l.Count > 1 { | ||
| return nil, fmt.Errorf("There is more then one result for SecurityGroup name: %s", name) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes securitygroup rules that target other securitygroup within a project. Authorization requests now include the target securitygroup's ownership scope, source group lookup are restricted to the same project, and project-owned source groups use the correct project account name.
Unit tests cover project and account ownership, while the acceptance test verifies project-scoped security group targeting. Both pass locally.