GH-51638: [CI][C++][Parquet] Update expected JSON output in parquet-reader-test for simdjson 5.0 - #51661
Open
tadeja wants to merge 1 commit into
Open
GH-51638: [CI][C++][Parquet] Update expected JSON output in parquet-reader-test for simdjson 5.0#51661tadeja wants to merge 1 commit into
tadeja wants to merge 1 commit into
Conversation
github-actions
Bot
added
Component: Parquet
Component: C++
awaiting committer review
tadeja
marked this pull request as ready for review
September 30, 2026 17:23
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The version-specific expectations match the generated field order, and relevant C++ CI checks pass.
Review effort: Balanced
Findings: None
What changed in this PR
Updates Parquet reader test expectations for simdjson 5.0 formatting while preserving compatibility with 4.x.
Changes:
- Selects expected JSON formatting by simdjson major version.
- Updates four affected JSON-output tests.
| File | Description |
|---|---|
cpp/src/parquet/reader_test.cc |
Adds simdjson 5.x expected output variants. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See #51638 -
fractured_jsonformatting changes with the new simdjson version 5.0 (whitespace, line breaks, key order in tables),cause
parquet-reader-testto fail on four of its testsTestJSONWithLocalFile.JSONOutput...What changes are included in this PR?
Check
simdjson::SIMDJSON_VERSION_MAJOR, and for>= 5use the new expected formatting (JSON content hasn't changed).Keep existing expected output formatting for simdjson 4.x
Are these changes tested?
Yes, CI runs pass.
Are there any user-facing changes?
No, only test changes.
Was AI used for this PR?
PR code and description written by:
Reviewed before submission by:
parquet-reader-testwith MSYS2 simdjson 5.0.1 #51638