GH-51656: [R] Polish NEWS.md and README for 26.0.0 - #51657
Conversation
github-actions
Bot
added
Component: R
Component: Documentation
awaiting committer review
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Several user-facing statements overstate or inaccurately describe IPC terminology, Azure dependencies, and thread safety.
Review effort: Balanced
Findings: 3
Open (3)
What changed in this PR
Updates R release documentation for 26.0.0.
Changes:
- Adds release notes for new features, deprecations, and fixes.
- Documents Azure Blob Storage and Arrow IPC support.
| File | Description |
|---|---|
r/README.md |
Updates supported formats and cloud storage. |
r/NEWS.md |
Adds 26.0.0 release highlights. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jonkeane
left a comment
jonkeane
left a comment
There was a problem hiding this comment.
A few minor rearranging proposals in the minor fixes section
| - `register_scalar_function()` now checks that the names in `in_type` match | ||
| the arguments of `fun`, instead of silently ignoring them (#37761). |
There was a problem hiding this comment.
This might be more than a minor improvement, IMO. At the very least, it might be good to be at the top fo the list?
There was a problem hiding this comment.
I see what you're saying but we order them by first function named as per tidyverse style stuff
There was a problem hiding this comment.
Will put in breaking changes
| the arguments of `fun`, instead of silently ignoring them (#37761). | ||
| - `str_replace()` with an `NA` replacement now returns `NA` for matched | ||
| elements, matching stringr (@Gosling-dude, #33432). | ||
| - `summarise()` after `arrange()` now works (#45373). |
There was a problem hiding this comment.
Same with this, this seems bigger than (the last item of) minor improvements
github-actions
Bot
added
awaiting review
github-actions
Bot
added
awaiting change review
8b65ea4 to
5145f7a
Compare
Rationale for this change
Update NEWS and README for release
What changes are included in this PR?
Update NEWS and README for release
Are these changes tested?
No
Are there any user-facing changes?
No
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: