Skip to content

GH-51651: [C++][CI] Fix static linking for system Abseil and bundled GCS - #51653

Open
tadeja wants to merge 2 commits into
apache:mainfrom
tadeja:51651-abseil-and-gcs
Open

GH-51651: [C++][CI] Fix static linking for system Abseil and bundled GCS#51653
tadeja wants to merge 2 commits into
apache:mainfrom
tadeja:51651-abseil-and-gcs

Conversation

@tadeja

@tadeja tadeja commented Sep 30, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Rationale for this change

Static Arrow linking can fail for bundled GCS and system Abseil.

What changes are included in this PR?

Expor Abseil dependencies via CMake target and pkg-config metadata.

Are these changes tested?

To be additionally verified by CI.

Are there any user-facing changes?

This improves downstream static linking.

Was AI used for this PR?

PR code and description written by:

  • Human
  • AI

Reviewed before submission by:

  • Human
  • AI
  • Not reviewed

@tadeja tadeja changed the title GH-51651: Fix static link failure for system Abseil and bundled GCS GH-51651: [C++][CI] Fix static link failure for system Abseil and bundled GCS Sep 30, 2026
@tadeja

tadeja commented Sep 30, 2026

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit test-debian-13-cpp test-debian-experimental-cpp-gcc-15

@github-actions

github-actions Bot commented Sep 30, 2026

Copy link
Copy Markdown 
Unable to match any tasks for `test-debian-13-cpp`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/36710999199

@raulcd

raulcd commented Sep 30, 2026

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-debian-13-cpp-* test-debian-experimental-cpp-gcc-15

@github-actions

github-actions Bot commented Sep 30, 2026

Copy link
Copy Markdown

Revision: d441634

Submitted crossbow builds: ursacomputing/crossbow @ actions-acf6d722bf

Task Status
test-debian-13-cpp-amd64 GitHub Actions
test-debian-13-cpp-i386 GitHub Actions
test-debian-experimental-cpp-gcc-15 GitHub Actions

@tadeja

tadeja commented Sep 30, 2026

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit test-ubuntu-22.04-cpp-bundled

raulcd
raulcd reviewed Sep 30, 2026
View reviewed changes
Comment thread cpp/cmake_modules/ThirdpartyToolchain.cmake
# Bundled google-cloud-cpp needs system Abseil for static linking.
# Abseil .pc files include indirect link dependencies that base -labsl_* flags omit
find_package(PkgConfig QUIET)
if(PkgConfig_FOUND)

@raulcd raulcd Sep 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add an output message if not?

@tadeja tadeja Sep 30, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, added.

@github-actions github-actions Bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Sep 30, 2026
@github-actions

github-actions Bot commented Sep 30, 2026

Copy link
Copy Markdown

Revision: d441634

Submitted crossbow builds: ursacomputing/crossbow @ actions-21d737ae20

Task Status
test-ubuntu-22.04-cpp-bundled GitHub Actions

@github-actions github-actions Bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Sep 30, 2026
@tadeja
tadeja marked this pull request as ready for review September 30, 2026 13:04
Copilot AI balanced review requested due to automatic review settings September 30, 2026 13:04
Copilot AI reviewed Sep 30, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The CMake and pkg-config dependency exports consistently address the reported static-link failures.

Review effort: Balanced
Findings: None

What changed in this PR

Exports system Abseil dependencies needed by static Arrow builds using bundled GCS.

Changes:

  • Adds Abseil targets to Arrow’s static CMake interface.
  • Adds matching dependencies to static pkg-config metadata.
File Description
cpp/​src/​arrow/​CMakeLists.txt Exports required Abseil CMake targets.
cpp/​cmake_modules/​ThirdpartyToolchain.cmake Adds available Abseil packages to arrow.pc.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@tadeja tadeja changed the title GH-51651: [C++][CI] Fix static link failure for system Abseil and bundled GCS GH-51651: [C++][CI] Fix static linking for system Abseil and bundled GCS Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raulcd raulcd raulcd left review comments
Copilot code review Copilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

awaiting changes Awaiting changes Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tadeja @raulcd