Fix importdirectory command description layout - #6562
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
utafrali
approved these changes
Sep 24, 2026
utafrali
left a comment
There was a problem hiding this comment.
The fix correctly removes the embedded newline and the regression test properly asserts against the actual newline character. One minor defect: replacing \n with a trailing space introduces a double space where the next concatenated string literal also begins with a space.
| + " will be displayed indicating the source directory is empty, but no error is thrown.\n" | ||
| + " will be displayed indicating the source directory is empty, but no error is thrown. " | ||
| + " Bulk import only takes 2 arguments: <directory> true|false"; | ||
| } |
There was a problem hiding this comment.
The trailing space added here creates a double space when concatenated with the next string literal, which already starts with a space. The result is "...but no error is thrown. Bulk import only takes 2 arguments..." (two spaces before "Bulk"). Drop the trailing space since the following string provides the separator:
+ " will be displayed indicating the source directory is empty, but no error is thrown."This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
importdirectorycommand description so the shell formatter keeps the continuation aligned.Testing
mvn -pl shell -am -Dtest=ImportDirectoryCommandTest -DfailIfNoTests=false -DskipFormat test— passed with Java 21.mvn -pl shell -am -DskipTests -DverifyFormat verify— passed with Java 21.git diff --check— passed.Fixes #6544