Skip to content

Write minicluster unit test cluster dirs to target/mini-tests so CI keeps their logs - #6558

Open
DomGarguilo wants to merge 1 commit into
apache:mainfrom
DomGarguilo:improveTimeoutLogging
Open

DomGarguilo wants to merge 1 commit into
apache:mainfrom
DomGarguilo:improveTimeoutLogging

Conversation

@DomGarguilo

Copy link
Copy Markdown
Member

MiniAccumuloClusterClasspathTest has been hanging in github CI and timing out. Its logs are not saved as an artifact on timeout because the log dir is wiped before the CI can save it.

This PR moves the cluster dirs for the minitcluster tests into target/mini-tests via a small new helper so the logs are properly uploaded next time it hangs.

This also fixes an a small existing but where MiniAccumuloClusterClasspathTest was resuing MiniAccumuloClusterTest's directory name.

This doesn't fix the test hanging it will just give us more info next time it does hang.

@DomGarguilo DomGarguilo added this to the 4.0.0 milestone Sep 23, 2026
@DomGarguilo DomGarguilo self-assigned this Sep 23, 2026
@dlmarion

Copy link
Copy Markdown
Contributor

I have definitely noticed this issue, but never really dug in. The parent pom sets java.io.tmpdir for both the surefire and failsafe plugins. The @TempDir should use that value. I wonder if it's not because the minicluster pom overrides the surefire plugin configuration there and java.io.tmpdir is not set.

@DomGarguilo

DomGarguilo commented Sep 24, 2026 •

Copy link
Copy Markdown
Member Author

I have definitely noticed this issue, but never really dug in. The parent pom sets java.io.tmpdir for both the surefire and failsafe plugins. The @TempDir should use that value. I wonder if it's not because the minicluster pom overrides the surefire plugin configuration there and java.io.tmpdir is not set.

I think the dir just gets cleared by the time the CI tries to upload the logs. I can't find it now but I saw an error along those line in the logs when i saw the timeout happen.

Edit: found it:

No files were found with the provided path: ./**/target/**/mini-tests/**/logs/. No artifacts will be uploaded.

@ctubbsii ctubbsii modified the milestones: 4.0.0-alpha-1, 4.0.0 Sep 24, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants