You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
MiniAccumuloClusterClasspathTest has been hanging in github CI and timing out. Its logs are not saved as an artifact on timeout because the log dir is wiped before the CI can save it.
This PR moves the cluster dirs for the minitcluster tests into target/mini-tests via a small new helper so the logs are properly uploaded next time it hangs.
This also fixes an a small existing but where MiniAccumuloClusterClasspathTest was resuing MiniAccumuloClusterTest's directory name.
This doesn't fix the test hanging it will just give us more info next time it does hang.
I have definitely noticed this issue, but never really dug in. The parent pom sets java.io.tmpdir for both the surefire and failsafe plugins. The @TempDir should use that value. I wonder if it's not because the minicluster pom overrides the surefire plugin configuration there and java.io.tmpdir is not set.
I have definitely noticed this issue, but never really dug in. The parent pom sets java.io.tmpdir for both the surefire and failsafe plugins. The @TempDir should use that value. I wonder if it's not because the minicluster pom overrides the surefire plugin configuration there and java.io.tmpdir is not set.
I think the dir just gets cleared by the time the CI tries to upload the logs. I can't find it now but I saw an error along those line in the logs when i saw the timeout happen.
Edit: found it:
No files were found with the provided path: ./**/target/**/mini-tests/**/logs/. No artifacts will be uploaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MiniAccumuloClusterClasspathTest has been hanging in github CI and timing out. Its logs are not saved as an artifact on timeout because the log dir is wiped before the CI can save it.
This PR moves the cluster dirs for the minitcluster tests into
target/mini-testsvia a small new helper so the logs are properly uploaded next time it hangs.This also fixes an a small existing but where
MiniAccumuloClusterClasspathTestwas resuingMiniAccumuloClusterTest's directory name.This doesn't fix the test hanging it will just give us more info next time it does hang.