Conversation
ctubbsii
requested changes
Sep 25, 2026
| retry.logCompletion(log, "Modifying properties for table " + tableName); | ||
| return props; | ||
| } catch (ConcurrentModificationException cme) { | ||
| } catch (ConcurrentModificationException | TableNotFoundException cme) { |
Member
There was a problem hiding this comment.
This catch block triggers a retry, but that doesn't make sense for the case where the table doesn't exist. It only makes sense for concurrent modifications.
Contributor
Author
There was a problem hiding this comment.
I added this catch because of the call to tryToModifyProperties above, in that method I had to to add the TableNotFoundException as the method was throwing TableNotFoundException wrapped in AccumuloException. So now I think this method has to accommodate for that
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove wrapping TableNotFoundException in AccumuloException in a few
TableOperations.javamethods. This way the methods can throw TableNotFoundException directly.closes #5602