Conversation
Amemeda
marked this pull request as ready for review
September 18, 2026 17:48
DomGarguilo
reviewed
Sep 24, 2026
| import org.apache.accumulo.manager.tableOps.FateEnv; | ||
| import org.apache.accumulo.server.ServerContext; | ||
|
|
||
| public class CustomFateManager extends Manager { |
Member
There was a problem hiding this comment.
I think we should make CustomFateManager abstract. That way future implementations are forced to override the createFateInstance() method. Right now if a new impl is created and someone forgets to override they will get the hardcoded SlowFateSplit which might not be intended.
Member
There was a problem hiding this comment.
Sorry I didn't explain super well but createFateInstance() should also be abstract so we are not returning the SlowFateSplit. Thats the important part so implementations are forced to decide what to return instead of accidentally returning SlowFateSplit.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored custom fate test files for maintainability according to the linked issue. The group of custom test files were moved into their own subpackage
test.src.main.java.org.apache.accumulo.test.fate.custom, and 2 new filesCustomFate.javaandCustomFateManager.javawere created to act as a super class to the following test classes:Custom FATE test objects
Super class
CustomFate.javaFlakyFate.javaFastFate.javaSlowFateSplit.javaCustom Manager test objects
Super class
CustomFateManager.javaFlakyFateManager.javaSlowFateSplitManager.javacloses #5837