Agitator bug fixes/improvments - #321
Merged
Merged
Conversation
dlmarion
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes 3 fixes/changes:
ENV_VARSdid not haveHADOOP_CONF_DIR/HADOOP_LOG_DIRso when a DataNode is restarted, they never registered so the cluster silently shrinksstopwas not actually stopping anything. It was sourcingenv.shfirst which exited if teh install path had moved, so it returned before actually killing anything. The fix was to only source it onstartwhich is the only place that is needed.AGTR_*) overrides were being ignored. Things were hardcoded and now these changes allow the user to properly set things.