Skip to content

refactor(github-actions): infer trusted build from google_credential in configure-remote - #3992

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:refactor/configure-remote-trusted-build
Sep 23, 2026
Merged

alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:refactor/configure-remote-trusted-build

Conversation

@alan-agius4

Copy link
Copy Markdown
Contributor

Remove the trusted_build input and treat the presence of google_credential as indicating a trusted build in the configure-remote action.

…in configure-remote

Remove the trusted_build input and treat the presence of google_credential
as indicating a trusted build.
@alan-agius4
alan-agius4 force-pushed the refactor/configure-remote-trusted-build branch from 0b97994 to 7f2dc44 Compare September 23, 2026 15:41

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the explicit trusted_build input from the Bazel remote configuration action, instead inferring it based on the presence of the google_credential input. Additionally, Node.js built-in imports in index.ts have been updated to use the node: prefix. There are no review comments to address.

@josephperrott josephperrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Sep 23, 2026
@alan-agius4
alan-agius4 merged commit 1ffbb25 into angular:main Sep 23, 2026
17 checks passed
@alan-agius4

Copy link
Copy Markdown
Contributor Author

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4
alan-agius4 deleted the refactor/configure-remote-trusted-build branch September 23, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants