fix(material/datepicker): avoid showing month label twice in calendar - #33844
Open
PreethiPantangi wants to merge 2 commits into
Open
PreethiPantangi wants to merge 2 commits into
PreethiPantangi wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(material/datepicker): avoid showing month label twice in calendar
MatCalendar always renders a header that displays the current month/year. MatMonthView can also render the month label inside the calendar grid when there are enough leading empty cells, causing the month to be displayed and announced twice. The in-grid label can't be made aria-hidden, as this affects NVDA's weekday column count.
Fix
Add a showLabel input to MatMonthView, defaulting to true to preserve the behavior of standalone @docs-private usages. MatCalendar passes false since its header already displays the month/year. I also ran
pnpm approve-api datepicker, updating the golden API files for the datepicker package.Fixes #33763
Testing:
pnpm test datepickerBefore
Date.Picker.Before.mp4
After
Date.Picker.After.mp4