build: forward data and package.json to strict_deps_test - #34133
Merged
Merged
Conversation
angular-robot
Bot
added
the
area: build & ci
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes unnecessary ts-ignore comments from several CLI command files. Additionally, it updates the ts_project Bazel macro in tools/defaults.bzl to correctly handle package_json and data attributes in strict_deps_test. A review comment identifies a potential build failure in the ts_project macro, noting that package_json should be popped from kwargs before forwarding to _ts_project to avoid passing unexpected arguments.
alan-agius4
force-pushed
the
strict-deps-remove
branch
from
September 21, 2026 10:44
84040a1 to
9d74f84
Compare
alan-agius4
added
action: review
Forward `data` and `package.json` to `strict_deps_test` in the `ts_project` macro. With `data` assets included in strict deps checks, the `@ts-ignore strict-deps` workarounds on markdown asset imports across CLI commands are no longer needed.
alan-agius4
force-pushed
the
strict-deps-remove
branch
from
September 21, 2026 10:49
9d74f84 to
ca3b99a
Compare
clydin
approved these changes
Sep 21, 2026
alan-agius4
added
action: merge
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward
dataandpackage.jsontostrict_deps_testin thets_projectmacro.With
dataassets included in strict deps checks, the@ts-ignore strict-depsworkarounds on markdown asset imports across CLI commands are no longer needed.