Skip to content

fix: retain the smithy HTTP handler memory leak patch - #799

Closed
lilienblum wants to merge 1 commit into
mainfrom
lilienblum/alien-370-http-handler-leak
Closed

lilienblum wants to merge 1 commit into
mainfrom
lilienblum/alien-370-http-handler-leak

Conversation

@lilienblum

Copy link
Copy Markdown
Contributor

The rollback in #796 restored @smithy/node-http-handler 4.12.0, which is deprecated because completed isolated HTTP/2 sessions retain their timeout and associated memory. Update the root lockfile to 4.12.1 and its required @smithy/types dependency, leaving the rest of the rollback intact.

Regenerated with pnpm --recursive update @smithy/node-http-handler --depth Infinity --lockfile-only --ignore-scripts. Removed unrelated tldts resolution churn from the generated diff. No manifest changes or overrides.

Validation:

  • Frozen pnpm install for @alienplatform/testing and its dependencies passed.
  • Confirmed AWS SSM resolves handler 4.12.1. Ran 100 real requests against a local HTTP/2 server with isolated sessions; all responses passed and no timeout resources remained after completion.
  • Testing package and dependency builds passed, followed by its TypeScript typecheck.
  • git diff --check passed.

Upstream release confirmation: smithy-lang/smithy-typescript#2258

Related to ALIEN-370.

Keep node-http-handler 4.12.1 while reverting the unrelated dependency batch. The deprecated 4.12.0 release retains HTTP/2 session timers after requests complete.
@greptile-apps

greptile-apps Bot commented Sep 30, 2026

Copy link
Copy Markdown

No reviewable files after applying ignore patterns.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T07:37:09.320968Z 3d24f6c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lilienblum

Copy link
Copy Markdown
Contributor Author

Closing this with the rest of the Renovate session.

@lilienblum lilienblum closed this Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant