Conversation
Assisted-by: Claude Code
|
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
nacos-community
left a comment
There was a problem hiding this comment.
Summary
This PR adds batch export and batch clone support for MCP servers (issue #14107): new v3 console APIs with ABORT/SKIP/OVERWRITE conflict policies, AI/maintainer-client plumbing for DIRECT/REF/STDIO endpoints, plus backend and frontend tests. The structure and test coverage are good and endpoints are properly authorized, but the OVERWRITE path has a data-loss correctness issue and the REF namespace routing has a behavioral regression, so requesting changes.
Suggestions
- Reorder OVERWRITE so the replacement draft is created and published before deleting the old server (or keep a fallback copy), and explicitly reject/guard source == target self-overwrite.
- Fall back to the caller namespaceId when REF endpoint data has a blank namespaceId, and add validation/test coverage for that case.
- Add catch blocks in both batch handlers to surface errors to the user.
Automated review by github-manager-bot
|
Detailed findings for the review above (CHANGES_REQUESTED): Findings
Automated comment by github-manager-bot |
Related issue: #14107
This PR adds batch export and batch clone support for MCP servers.
Highlights:
Validation: