fix(cli): render setup validation errors cleanly - #966
Draft
blafourcade wants to merge 2 commits into
Draft
blafourcade wants to merge 2 commits into
blafourcade wants to merge 2 commits into
Conversation
Keep unsupported user-scope combinations inside the command error boundary so intentional refusals print remedies without a stack trace. Document current registration and installation scope limits. Refs #891 AIDD-Session-Id: 01a111bd-4959-7be1-9ad4-093a46ef8295
Record the approved review and outcome challenge for #891, mark the plan reviewed, and clarify that dependency construction assertions apply to the setup action. AIDD-Session-Id: 01a111bd-4959-7be1-9ad4-093a46ef8295
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What & why
aidd setup --scope user --ai claude --plugins allnow prints the existing refusal and remedies and exits 1 without a stack trace or minified bundle dump. Help and README explain the shipped user-scope limits.🛠️ How it works
Construct
SetupFlowinside the existing command error boundary. Cover constructor refusals through command and built-binary tests, derive help support from the registry, and update the setup help snapshot. Domain validation and installation capabilities stay as shipped.🧪 How to verify
pnpm --dir cli test: 6,805 passed; one existing opt-in runtime test skipped.The unchanged startup update-check hook may construct dependencies before the setup action runs. The regression proves that a refused setup action does not create its own dependencies. Existing unrelated lint and Vitest deprecation warnings remain.
🔗 Linked issue
Closes #891
✅ I certify