refactor: derive routers from protocol metadata - #149
Merged
Merged
Conversation
…ling Signed-off-by: Frost Ming <me@frostming.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding or changing an ACP method previously required updating both its Agent/Client protocol declaration and a separate router registration. Move the wire method name, request/notification kind, unstable flag, optional-handler defaults, and adapters into
param_model/param_modelson the protocols. Both router entry points now delegate toMessageRouter.from_protocol.The common builder preserves legacy handler dispatch, extension methods, optional terminal responses, unstable gates, and separate request/notification handlers for
mcp/message. Config-option and elicitation conversions live in a private adapter module and are selected by protocol metadata. Model-only decorators on outgoing connection methods remain compatible with signature generation and legacy calls. No schema regeneration is included.Related issues
Follow-up to #148.
Testing
make check: all lockfile, pre-commit, type, and dependency checks passed.Docs & screenshots
Document route declarations and adapter options in the quickstart maintenance section.
Checklist
feat:,fix:).make gen-all) are called out if applicable.