Accept Temurin four field versions with build metadata - #1271
Open
Hashim1999164 wants to merge 1 commit into
Open
Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
normalizeVersion only converted pure four field versions like 18.0.1.1, so Temurin strings such as 26.0.2.1+1 failed the SemVer check. Fold the extra fields into build metadata and keep any existing +build suffix.
Contributor
|
This might be over engineering, but according to JEP322 there is no limit on how many numbers there can be in a version, not sure how much work it would be to just allow any arbitrary number of numbers. |
johnoliver
reviewed
Sep 21, 2026
| ['11.0.9.1', {version: '11.0.9+1', stable: true, latest: false}], | ||
| ['12.0.2.1.0', {version: '12.0.2+1.0', stable: true, latest: false}], | ||
| ['18.0.1.1-ea', {version: '18.0.1+1', stable: false, latest: false}], | ||
| ['26.0.2.1+1', {version: '26.0.2+1.1', stable: true, latest: false}], |
Contributor
There was a problem hiding this comment.
using the test cases of 26.0.2.1+1 -> 26.0.2+1.1 does leave it ambiguous if +1.1 is in the right order
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1270
Temurin publishes versions like
26.0.2.1+1.normalizeVersiononly rewrote pure four field strings (e.g.18.0.1.1), so those values failed the SemVer check on setup-java 6.x.convertVersionToSemvernow folds the extra numeric fields into SemVer build metadata and keeps any existing+buildsuffix (26.0.2.1+1->26.0.2+1.1).normalizeVersionmatches the same pattern.Test plan
npm test -- --testPathPatterns=util.test --coverage=falsenpm test -- --testPathPatterns=base-installer.test --testNamePattern=normalizeVersion --coverage=falsenpm run build