test: derive the channel unit specs - #701
Open
owenpearson wants to merge 1 commit into
Open
owenpearson wants to merge 1 commit into
owenpearson wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
owenpearson
force-pushed
the
uts/derive-channel
branch
from
September 22, 2026 15:04
b877c1c to
d01d09f
Compare
owenpearson
force-pushed
the
uts/derive-channel
branch
from
September 23, 2026 08:48
d01d09f to
8b7640c
Compare
owenpearson
force-pushed
the
uts/derive-channel
branch
from
September 23, 2026 09:42
8b7640c to
4b2490f
Compare
owenpearson
force-pushed
the
uts/derive-channel
branch
from
September 23, 2026 13:47
4b2490f to
c16bbab
Compare
owenpearson
force-pushed
the
uts/derive-channel
branch
from
September 23, 2026 14:02
c16bbab to
ac11201
Compare
owenpearson
added this pull request to stack #714
September 23, 2026 15:51
owenpearson
force-pushed
the
uts/derive-channel
branch
from
September 23, 2026 17:20
ac11201 to
aba9db6
Compare
Covers channel/publish.md, publish_result.md, history.md, get_message.md, update_delete_message.md, message_versions.md, annotations.md, idempotency.md and rest_channel_attributes.md. Three tests carry the deviation mark: the two covering RestChannel#setOptions, which the REST channel's options setter cannot accept, and RSL1i, where a REST publish never checks the message size. Two more assert what features.md contradicts and carry the spec_error mark. The adapted tests record the channel name encoding as it stands, including the space that travels as `+` and the unescaped name in Channel#status. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
owenpearson
force-pushed
the
uts/derive-channel
branch
from
September 23, 2026 17:38
aba9db6 to
8658317
Compare
owenpearson
force-pushed
the
uts/derive-channel
branch
from
September 24, 2026 12:51
8658317 to
9e3095b
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 7 of 9 in the UTS REST unit stack. Base:
uts/derive-types-encoding-presence.Derives
channel/publish.md,publish_result.md,history.md,get_message.md,update_delete_message.md,message_versions.md,annotations.md,idempotency.mdandrest_channel_attributes.md.Three tests carry
@deviation: the two coveringRestChannel#setOptions, where theREST channel's
optionssetter expects the kwargs dictChannels.getcollected and soraises
TypeErroron aChannelOptions; and RSL1i, where a REST publish never checks themessage size — the helper exists and only the realtime channel calls it.
Two carry
@spec_error:RSL1casserting an object payload travels unstringified,which RSL4c3 and RSL4d3 contradict, and
RSL1k/mixed-ids-in-batch-1expecting a generatedid that RSL1k1 and RSL1k3 between them rule out.
The adapted tests record the channel name encoding as it stands, which is where this area
holds two genuine correctness issues: a space travels as
+rather than%20, fromquote_plusinChannel.__init__— form encoding applied to a URL path — andChannel#statusinterpolates the name with no escaping at all, soa/baddresses thewrong resource. Both are recorded rather than fixed here.
Verification
453 passed, 29 skipped;ruff check ably/ test/clean.🤖 Generated with Claude Code