test: derive the type, encoding and presence unit specs - #700
Open
owenpearson wants to merge 1 commit into
Open
owenpearson wants to merge 1 commit into
owenpearson wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 41 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (14)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
owenpearson
force-pushed
the
uts/derive-types-encoding-presence
branch
from
September 22, 2026 15:04
65e4be2 to
65ad516
Compare
owenpearson
force-pushed
the
uts/derive-types-encoding-presence
branch
from
September 23, 2026 08:48
65ad516 to
9cf9174
Compare
owenpearson
force-pushed
the
uts/derive-types-encoding-presence
branch
from
September 23, 2026 09:42
9cf9174 to
1952fe2
Compare
owenpearson
force-pushed
the
uts/derive-types-encoding-presence
branch
from
September 23, 2026 13:47
1952fe2 to
f307d84
Compare
owenpearson
force-pushed
the
uts/derive-types-encoding-presence
branch
from
September 23, 2026 14:02
f307d84 to
e74393f
Compare
owenpearson
added this pull request to stack #714
September 23, 2026 15:51
owenpearson
force-pushed
the
uts/derive-types-encoding-presence
branch
from
September 23, 2026 17:20
e74393f to
c659325
Compare
Covers encoding/message_encoding.md, encoding/msgpack_interop.md, presence/rest_presence.md, and the types specs for messages, mutable messages, options, presence messages, tokens, paginated results and errors. The msgpack interop tests read fixtures from ably-common, which the pinned submodule predates, so they are gated on the fixture file being present. Ten tests carry the deviation mark, covering the presence get filters, PresenceMessage#size, href and cause on a deserialised error, the presence attributes a ProtocolMessage would supply, and the endpoint left unset. Three assert what protocol.md contradicts and carry the spec_error mark instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
owenpearson
force-pushed
the
uts/derive-types-encoding-presence
branch
from
September 23, 2026 17:38
c659325 to
25c757d
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 6 of 9 in the UTS REST unit stack. Base:
uts/derive-client-request-fallback.Derives
encoding/message_encoding.md,encoding/msgpack_interop.md,presence/rest_presence.md, and the types specifications for messages, mutable messages,options, presence messages, tokens, paginated results and errors.
The msgpack interop tests read fixtures from
ably-common, which the pinned submodulepredates, so they are gated on the fixture file being present.
Ten tests carry
@deviation: the presencegetfilters (clientId,connectionId),PresenceMessage#size,hrefandcauseon a deserialised error, the presence attributesa
ProtocolMessagewould supply, andendpointleft unset when none is given.Three carry
@spec_error: two TP3 cases asserting an outgoing presence action as thestring
"enter", andRSP4/history-pagination-1asserting wire action4is LEAVE, bothof which
protocol.mdcontradicts.The adapted tests record
ErrorInfoequality by identity,capabilityas aCapabilityobject rather than stringified JSON, and
PaginatedResult.headersas a list of pairs —each with the specification's expectation in a comment above and a note on whether it is
intentional or an open bug.
Verification
395 passed, 24 skipped;ruff check ably/ test/clean.🤖 Generated with Claude Code