test(server): fix flaky testSynchronousExecutorDoesNotLeakChainEntries - #1189
Merged
Merged
Conversation
Two bugs caused intermittent failures: 1. Latch count was taskCount (10) but each task generates TWO push notifications -> one for the Task event and one for the StatusUpdate event, both implementing StreamingEventKind -> so the latch could fire with 10 notifications still in flight. Fixed to taskCount * 2. 2. TOCTOU race between the while-loop exit and assertEquals: with a synchronous executor, pushTask runs inside compute()'s lambda before the chain entry is stored, so the latch can reach 0 when count is transiently 0. The while exited on count==0 but assertEquals re-read count and could see 1 if the processor stored the entry in between. Fixed by switching to a do-while that always sleeps before the first check and asserts on the captured count, not a fresh read. Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs caused intermittent failures:
Latch count was taskCount (10) but each task generates TWO push notifications -> one for the Task event and one for the StatusUpdate event, both implementing StreamingEventKind -> so the latch could fire with 10 notifications still in flight. Fixed to taskCount * 2.
TOCTOU race between the while-loop exit and assertEquals: with a synchronous executor, pushTask runs inside compute()'s lambda before the chain entry is stored, so the latch can reach 0 when count is transiently 0. The while exited on count==0 but assertEquals re-read count and could see 1 if the processor stored the entry in between. Fixed by switching to a do-while that always sleeps before the first check and asserts on the captured count, not a fresh read.