fix(server): recover failed terminal enqueues - #1185
Merged
ehsavoie merged 7 commits intoSep 28, 2026
Merged
Conversation
ehsavoie
self-requested a review
September 28, 2026 11:12
kabir
force-pushed
the
fix/1183-agent-emitter-terminal-event
branch
from
September 28, 2026 11:54
ec93811 to
a35a752
Compare
- Invoke onClose() inside synchronized block for atomic state updates - Deduplicate isFinalEvent() into parent EventQueue - Skip closed child queues during event dispatch - Decrement submittedFinalEvents instead of resetting to zero - Reset pendingFinalEvents in clearAwaitingFinalEvent() - Handle enqueue timeout and max-retries gracefully in DefaultRequestHandler Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Roll back the emitter terminal latch when enqueueing fails, and preserve fallback InternalError delivery after an interrupted enqueue by restoring the worker interrupt only after reporting the error.
mvn -pl server-common test(526 tests passed)Fixes #1183 🦕