Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @gclapps0612-cmd. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
wppoland
changed the title
|
help .e help .e verify i have my supporting military id verify i have my
supporting military id
…On Mon, Aug 17, 2026, 7:40 AM github-actions[bot] ***@***.***> wrote:
*github-actions[bot]* left a comment (WordPress/wordpress-develop#11699)
<#11699 (comment)>
Test using WordPress Playground
The changes in this pull request can previewed and tested using a WordPress
Playground <https://developer.wordpress.org/playground/> instance.
WordPress Playground <https://developer.wordpress.org/playground/> is an
experimental project that creates a full WordPress instance entirely within
the browser.
Some things to be aware of
- All changes will be lost when closing a tab with a Playground
instance.
- All changes will be lost when refreshing the page.
- A fresh instance is created each time the link below is clicked.
- Every time this pull request is updated, a new ZIP file containing
all changes is created. If changes are not reflected in the Playground
instance,
it's possible that the most recent build failed, or has not completed.
Check the list of workflow runs to be sure
<https://github.com/WordPress/wordpress-develop/actions/workflows/test-build-processes.yml>
.
For more details about these limitations and more, check out the Limitations
page <https://wordpress.github.io/wordpress-playground/limitations/> in
the WordPress Playground documentation.
Test this pull request with WordPress Playground
<https://playground.wordpress.net/wordpress.html?pr=11699>.
—
Reply to this email directly, view it on GitHub
<#11699?email_source=notifications&email_token=BXZWJXFGAYQW3WCWV7YZBAD5KLVJ3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMZRGU2TIMJSG4Y2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#issuecomment-5315541271>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BXZWJXH4HSHSTJDI4SQPNZL5KLVJ3AVCNFSNUABEKJSXA33TNF2G64TZHM3TKNRUGU3DKOJ3JFZXG5LFHM2DGNZSGE2TOMJVGKQXMAQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
wppoland
force-pushed
the
trac/64168
branch
from
September 13, 2026 07:39
0b33b42 to
2617bc2
Compare
`WP_REST_Templates_Controller::prepare_item_for_response()` can return `origin: null` for templates that do not come from a customizer/theme/plugin source. The schema previously declared `origin` as `string`, so responses with `origin: null` failed schema validation under strict-mode REST clients. This commit widens the schema to match the runtime behavior: * `origin` becomes `[ string, null ]`. Adds tests covering: * The `origin` schema accepts `null`. * A theme template returns `null` for `origin` against the new schema. (Note: `modified` returning `null` was separately resolved in [62941] / #65728). See #64168.
wppoland
force-pushed
the
trac/64168
branch
from
September 25, 2026 06:24
c848507 to
0b16d7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/64168
WP_REST_Templates_Controller::prepare_item_for_response()can return:origin: nullfor templates that do not come from a customizer/theme/plugin sourceThe schema previously declared
originasstring, so responses withorigin: nullfailed schema validation under strict-mode REST clients.This PR widens the schema to match runtime behavior:
originbecomes[ string, null ]Tests cover:
originschema acceptsnullnullfororiginagainst the new schema(Note:
modifiedreturningnullwas separately resolved in trunk in [62941] / #65728).Complements GH-10441.
Use of AI Tools
AI assistance: Yes
Tool(s): Antigravity IDE
Model(s): Gemini 2.5 Pro
Used for: Code analysis, conflict resolution, test suite updates, and patch verification. All changes were manually reviewed and tested locally.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.