Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Tested PR #11697 locally against current trunk. Environment:
Results:
The PR behavior looks correct to me: case-only email changes do not trigger the email-change notification or clear the activation key, while genuinely different email changes still trigger the notification. |
|
@GeorgeWebDevCy thank you for the test report, and sorry it sat unanswered for so long — that's on me, not on the quality of the report. Reproducing the three regression tests, running the full For anyone arriving later, the substance of what was verified on 2026-06-01, against
I'll carry this over to #52976 so the testing is recorded on the ticket rather than only here, since that's where a committer will look. |
@wppoland don't worry about it I understand. I have only recently started contributing after being at WCEU 2026 contributor day. I am teaching myself how to contribute. Not sure if I am following SOP. I am busy with freelancing but when I have some free time I just jump on and look for something to work on so don't worry about it :) |
fcdfece to
09f5591
Compare
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
09f5591 to
4658fbf
Compare
…()` and `wp_update_user()`. Email addresses are case-insensitive in their domain part (per RFC 5321) and treated as such by virtually all mail providers in the local part too. Previously, comparing `user_email` with `!==` could: * Reset `user_activation_key` even when only the case of an email changed. * Trigger the email-change notification for a case-only "change". This replaces those strict comparisons with `strcasecmp()` and adds tests for both code paths, including a regression test that case-only changes do not invalidate an existing password reset key. Complements WordPressGH-9196 with proper PHPUnit coverage. See #52976.
cb92deb to
021113e
Compare
Trac ticket: https://core.trac.wordpress.org/ticket/52976
Email addresses are case-insensitive in their domain part (per RFC 5321) and treated as such by virtually all mail providers in the local part too. Previously, comparing
user_emailwith!==could:user_activation_keyeven when only the case of an email changedThis PR replaces those strict comparisons with
strcasecmp().Tests cover:
send_email_change_emailuser_activation_keyComplements GH-9196 with proper PHPUnit coverage. Narrower scope than GH-9196 (focused on
user.phponly); happy to expand to admin/multisite call sites in a follow-up if reviewers prefer one bundled change.Use of AI Tools
AI assistance: Yes
Tool(s): Antigravity IDE
Model(s): Gemini 2.5 Pro
Used for: Code analysis, conflict resolution, test suite updates, and patch verification. All changes were manually reviewed and tested locally.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.