Conversation
CI ran outside pull requests two ways, and with a limited runner pool the duplicate work queues behind checks on open PRs, so it costs review latency rather than just wasted minutes. - Drop the push trigger from ci.yml and wasm.yml, so both run on PRs only - Remove the "Full test suite before publish" job from release.yml and rewire publish-crate's needs. Pushing a release tag re-ran fmt, clippy, the full test suite and a doc build on a commit whose PR had already checked all four. release.yml keeps its tag trigger — it is a release build, not a check. Its validate job stays, since that verifies the tag against the Cargo.toml version, which is genuinely release-time work. Closes V2-1353 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
dirvine
approved these changes
Sep 28, 2026
dirvine
left a comment
Member
There was a problem hiding this comment.
Reviewed by Hermes Agent (dirvine identity), per <@UDK3BBUE8>'s request.
CI-only change, verified against head 6a92b25:
- ci.yml / wasm.yml: push triggers removed; pull_request triggers unchanged.
- release.yml: removes the pre-publish 'test' job; publish-crate is now gated on validate only (version format + Cargo.toml version match).
Note: this is a deliberate reduction in release-path testing — crates.io publishes are no longer preceded by fmt/clippy/full test/doc on the tag. Flagging for awareness; approved as delivered since it is the intent of the set (runner economy). CI on head: all green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a six-repo change (V2-1353) making repo CI run on pull requests only. CI ran outside pull
requests two ways here, and with a limited runner pool the duplicate work queues behind checks on
open PRs.
push:trigger fromci.ymlandwasm.ymlFull test suite before publishjob fromrelease.ymland rewirepublish-crate'sneeds. Pushing a release tag re-ran fmt, clippy, the full test suite and a doc build against acommit whose PR had already checked all four.
release.ymlkeeps its tag trigger — it is a release build, not a check — and keeps itsvalidatejob, which verifies the tag against the Cargo.toml version and so is genuine release-time work.
Linear issue
Closes V2-1353
Risk tier
Compatibility
Semver impact
No crate source changes — only
.github/workflows, so this needs no version bump of its own.Test evidence
T0: repo CI only.
release.ymlhas no job left with aneeds:pointing at thedeleted
testjob:publish-crateis nowneeds: [validate]andreleasewas alreadyneeds: [validate, publish-crate].mainand no workflow targeted any other branch, so no check losescoverage;
ci.ymlandwasm.ymlkeep theirpull_requesttriggers unchanged.New dependency
none
ADR
n/a
Mitigation / rollback
Revert this commit; the triggers come back exactly as they were. If an off-PR run turns out to
have been load-bearing, that workflow's trigger can be restored on its own without touching the
other five repos.
🤖 Generated with Claude Code