Conversation
The push triggers on main and rc-* re-ran the exact checks that had just passed on the PR head. The organisation's runner pool is small enough that the duplicate work queues behind checks on open PRs, so the second run costs real review latency rather than just wasted minutes. - Drop the push trigger from ci.yml (MSRV, fmt, clippy, tests) - Drop the push trigger from adr-governance.yml pr-checks.yml, claude.yml and the tag-triggered release.yml are unchanged. release.yml carries no CI gate — its validate job only checks the tag against the Cargo.toml version. The default branch is main and nothing targets another branch, so no check loses coverage. Closes V2-1353 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
dirvine
approved these changes
Sep 28, 2026
dirvine
left a comment
Member
There was a problem hiding this comment.
Reviewed by Hermes Agent (dirvine identity), per <@UDK3BBUE8>'s request.
CI-only change, verified against head 945b587:
- ci.yml: removes the push trigger on main / rc-*; pull_request trigger unchanged — no effect on PR gating.
- adr-governance.yml: removes the push trigger on main/master; PR trigger unchanged.
No source changes, no secrets. CI on head: fully green (builds, clippy, MSRV, security audit, storage fs suite, WebRTC devnet, ADR validation).
jacderida
deleted the
chrisoneil/v2-1353-ci-run-repo-checks-only-on-pull-requests-across-all-six
branch
September 28, 2026 21:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a six-repo change (V2-1353) making repo CI run on pull requests only. The push triggers on
mainandrc-*re-ran the exact checks that had just passed on the PR head, and with a limitedrunner pool that duplicate work queues behind checks on open PRs — so it costs review latency, not
just wasted minutes.
push:trigger fromci.yml(MSRV, fmt, clippy, tests)push:trigger fromadr-governance.ymlpr-checks.ymlandclaude.ymlare untouched, andrelease.ymlkeeps its tag trigger. It carriesno CI gate to remove — its
validatejob only checks the tag against the Cargo.toml version.Linear issue
Closes V2-1353
Risk tier
Compatibility
Semver impact
No crate source changes — only
.github/workflows, so this needs no version bump of its own.Test evidence
T0: repo CI only.
pull_requestagainstmain+rc-*, unchanged from before.mainand no workflow targeted any other branch, so every job that ranon a push also ran on the PR — no check loses coverage.
release.ymlwas read through: no job runs fmt, clippy or tests, so nothing there neededchanging.
New dependency
none
ADR
n/a
Mitigation / rollback
Revert this commit; the triggers come back exactly as they were. If an off-PR run turns out to
have been load-bearing, that workflow's trigger can be restored on its own without touching the
other five repos.
🤖 Generated with Claude Code