Repository navigation
adding unique id to fault categories - #42
Conversation
…dding-ids # Conflicts: # src/main/resources/wfc/faults/fault_categories.json
Stranger6667
left a comment
Stranger6667
left a comment
There was a problem hiding this comment.
It would be nice to add this new field to the report schema too, otherwise looks good to me :)
|
@Stranger6667 sounds good. I ll do it in a different PR |
|
@Stranger6667 btw, would you have any use if those schema files were published in a PyPi package, automatically updated at each new WFC release? right now I m just publishing them for Java on Maven Central. but can (relatively easily) add them to PyPi as well if needed |
|
Thanks! Yes, that would be useful. Right now I keep a hand-copied report schema in the tests, and it drifts with every WFC release. A PyPI package would let me validate the reports against the real upstream schema as a dev dependency. I'd rather not add a runtime dependency, so the auth schema will stay vendored for now :) |
2 participants
No description provided.