Document vendored Bulma style.css and add CI guard against .scss collisions - #2069
Merged
Merged
Conversation
style.css is a pre-compiled Bulma snapshot with hand edits and no Sass build, which isn't obvious to contributors. A sibling style.scss silently shadowed it in USRSE#2026. Add a header comment and a docs/details.md section explaining how to change styles, plus a CI job that fails when a Sass file would compile to the path of an existing static .css file. Part of USRSE#2063 (phases 1 and 2). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 of 5 tasks
Member
Author
|
@USRSE/usrse-maintainers Please review, thanks! |
exoticDFT
approved these changes
Sep 30, 2026
exoticDFT
left a comment
exoticDFT
left a comment
Member
There was a problem hiding this comment.
Thanks for noticing this and fixing the issue. I had a feeling we did some compilation of the style.css, but couldn't find that information either before I merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2063 (Phases 1 and 2).
Summary
assets/css/style.cssis a pre-compiled Bulma snapshot with hand-written edits and no Sass build step. Nothing in the repo said so, which is how #2026'sstyle.scssended up silently shadowed by it (fixed in #2062). This PR makes that visible and catches it automatically:style.css: explains what the file is, says to add custom rules at the end, and warns against addingstyle.scss.docs/details.md. It explains what Bulma is, howstyle.cssis maintained today, and the stylesheet load order in_includes/head.html(style.cssloads beforereboot.cssandbootstrap.css, so equal-specificity rules in those files win).css-collisionjob inlinting.yaml. It fails a PR if any tracked.scss/.sassfile (excluding_-prefixed partials, which Jekyll doesn't output) sits next to a.cssfile with the same name. It's a few lines of shell with no dependencies and no network access.No visual change: the built
style.cssdiffers frommainonly by the new comment.Test plan
.scss/.sassfiles exist)_sass/_bulma.scss,assets/css/_part.scssnext to_part.css, and a non-collidingother.scssall pass;style.scssnext tostyle.cssandextra.sassnext toextra.csseach produce an error and exit 1bundle exec jekyll buildsucceeds; builtstyle.cssdiff vsmainis only the header comment🤖 Generated with Claude Code