Skip to content

fix(docx): align fresh-install snapshots with docx 9.8 - #3139

Open
nperez0111 wants to merge 1 commit into
mainfrom
fix/fresh-install-docx-snapshots
Open

nperez0111 wants to merge 1 commit into
mainfrom
fix/fresh-install-docx-snapshots

Conversation

@nperez0111

@nperez0111 nperez0111 commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Update the DOCX exporter dependency and lockfile to docx 9.8.0, the version selected by the fresh-install dependency update.
  • Regenerate the five affected DOCX XML snapshots. The newer docx version deduplicates built-in styles against our imported styles; it also changes an image identifier, the table grid widths, and document relationships.
  • Addresses the four DOCX snapshot failures in fresh install tests run 36540747070.

Verification

  • DOCX exporter unit tests: 8/8 passing.
  • Frozen-lockfile installation and package lint: passing.
  • Full local suite could not be verified because of unrelated missing local prerequisites (typst compiler artifact, PDF fonts, certificates, and Playwright Chromium).

Visual review needed

Please compare DOCX visual output against the previous version before merging, especially the table in the shared test document: its serialized grid changes from 100/100/100 to 2407/4212/2407, which may affect layout despite autofit. Also check heading/body styles and locale formatting after built-in style deduplication. Passing XML snapshots do not establish visual parity.

Summary by CodeRabbit

  • Chores
    • Updated the DOCX export dependency.

@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
blocknote Error Error Sep 29, 2026 9:13am UTC
blocknote-website Error Error Sep 29, 2026 9:13am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 091b35d8-b925-429a-b971-60dec48b01b4

📥 Commits

Reviewing files that changed from the base of the PR and between 7adf895 and 6b8e7b1.

⛔ Files ignored due to path filters (6)
  • packages/xl-docx-exporter/src/docx/__snapshots__/basic/document.xml is excluded by !**/__snapshots__/**
  • packages/xl-docx-exporter/src/docx/__snapshots__/basic/styles.xml is excluded by !**/__snapshots__/**
  • packages/xl-docx-exporter/src/docx/__snapshots__/noLocale/styles.xml is excluded by !**/__snapshots__/**
  • packages/xl-docx-exporter/src/docx/__snapshots__/withCustomOptions/document.xml.rels is excluded by !**/__snapshots__/**
  • packages/xl-docx-exporter/src/docx/__snapshots__/withLocale/styles.xml is excluded by !**/__snapshots__/**
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • packages/xl-docx-exporter/package.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The DOCX exporter package updates its docx dependency range from ^9.6.1 to ^9.8.0.

Changes

DOCX dependency update

Layer / File(s) Summary
Update DOCX dependency range
packages/xl-docx-exporter/package.json
The package manifest changes the docx dependency range from ^9.6.1 to ^9.8.0.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 6b8e7

No actionable merge-blocking issue is established. A visual comparison of representative documents remains advisable before release.

Architecture Summary

Architecture risk: 🔵 Low · up to 6b8e7

The change affects 1 system.

Changed systems: packages/xl-docx-exporter

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — packages/xl-docx-exporter (library) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in packages/xl-docx-exporter/package.json: The docx dependency requirement changed from ^9.6.1 to ^9.8.0.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the DOCX snapshot alignment with docx 9.8, which matches the main change.
Description check ✅ Passed The description clearly covers the dependency update, snapshot changes, rationale, test results, limitations, and required visual review. It does not use every template heading or include the checklis…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the package line,
And sees the version climb.
The DOCX bundle hops ahead,
With fresh numbers in its stead.
Then nibble leaves and rest.

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://TypeCellOS.github.io/BlockNote/pr-preview/pr-3139/

Built to branch gh-pages at 2026-09-29 09:23 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

This branch had an error being deployed

2 failed deployments
Preview – blocknote — 6b8e7b1f Deployed Sep 29, 2026 by vercel[bot]
Preview – blocknote-website — 6b8e7b1f Deployed Sep 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant