Conversation
generate_telemt_config() takes a destination path and writes the TOML there — it does not print it. This test captured its stdout instead, so `cfg` was always empty and both config assertions were decided by that emptiness rather than by the generated config: - "client_mss omitted when off" passed *vacuously*: grep found nothing in an empty string, so it reported "absent" no matter what the product did, including when client_mss was emitted unconditionally. - "client_mss emitted when set to tspu" could never pass on any platform. Demonstration: against a product mutated to always emit `client_mss = "tspu"`, the old test produced byte-identical output to the unmutated product (8 tests, 1 failure both times). It had no signal. Write to a temp destination and grep that file, and add an explicit "config is written" assertion so that if generation ever fails the test fails loudly instead of passing vacuously again. Verified: the repaired test passes on Debian 12, Ubuntu 22.04/24.04, Alpine 3.20 and Fedora 41, and now fails correctly under both mutations (emission removed, and emission made unconditional) where the old test caught neither.
rvalitov
marked this pull request as ready for review
September 17, 2026 13:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #144
Problem
generate_telemt_config()takes a destination path and writes the TOML there — it does not print it. This test captured its stdout instead:cfgis therefore always empty, so both config assertions were decided by that emptiness rather than by the generated config:grepfound nothing in an empty string, so it reportedabsentregardless of what the product did — including whenclient_msswas emitted unconditionally.Demonstrated
Against a product mutated to always emit
client_mss = "tspu", this test produced byte-identical output to the unmutated product:It had no signal at all.
Fix
Write to a temp destination and grep that file. An explicit "config is written" assertion is included so that if generation ever fails, the test fails loudly instead of passing vacuously again.
Testing
Found by running the existing suite across a distro matrix; this was the one failure common to every platform, which is what pointed at the test rather than at the product.