update to naga v0.30 and fix output file mismatch - #655
Firestar99 wants to merge 3 commits into
Conversation
nazar-pc
left a comment
There was a problem hiding this comment.
require SpirvBuilder to be aware what targets rust-gpu has, which we specifically wanted to avoid when I refactored our target definitions
dll-suffix/exe-suffix/staticlib-suffix fields of the target specification are designed for this purpose, are they not usable for this purpose?
|
Sure, I could easily add a formatting template here at the "dll-suffix" property. Rather, the question is whether Spirvbuilder should be aware of what targets exist. In the past, I've explicitly decided against that:
Target parsing happens here in the backend, but we need the target spec before invoking the backend. The question is whether I want to break that guarantee for some well-known targets. For the benefit that some build artifacts are now called |
|
When I call As for backwards compatibility, I'm not sure how valuable that is in practice and how it is supposed to be used, and how much testing goes into it in practice. I kind of assume one should use a compatible version of the builder and compiler, ideally from the same exact revision, but that is just me. |
In theory yes, in practice I don't know if rustc does any sort of special checks on file paths that may be influenced by us writing in a different location. |
42d2720 to
4c0c0b9
Compare
I've been using this workaround for a while but never fixed it upstream:
Merging this PR will break this workaround, as the file will be called
*.spvbut contain wgsl source code. Naming it*.wgslis possible, but would require SpirvBuilder to be aware what targets rust-gpu has, which we specifically wanted to avoid when I refactored our target definitions.