Repository navigation
syscall: preserve Cygwin UNC roots in ownership walks - #1113
Conversation
|
@sdbbs please test |
|
Thanks @steadytao :
I'm not sure exactly how, I'd need an executable; unfortunately I'm too busy right now to build from source. I noticed on https://packages.msys2.org/packages/rsync there was a ... so I updated MSYS2 with If you have a suggestion how can I obtain an executable quickly, I don't mind testing. Thanks again for the help! |
|
@sdbbs Just pulled the build from the Cygwin CI job. Let me know if it doesn't work. |
This comment was marked as resolved.
This comment was marked as resolved.
|
Chill mate, it happens. You could've easily installed all that missing dependencies with cygwin |
|
Eh I do more or less agree on the fact that AI does piss me off a lot of the time. But, yeah, preferably dont be overly doomer with things; we can strive to do better. |
|
Thank you for testing nonetheless. |
|
Thanks for merging - and sorry about my burst (handling this issue was only the final thing in that day of mine, where also everything else went wrong); I have edited my comment, and uploaded the missing script. Thanks again! |
|
It is no worries at all. I completely understand where the frustration comes from and we all need time to get that out occasionally. Thank you for reporting the issue and helping me confirm this fix works. |
Fixes #1105
Summary
Preserve
//server/shareas the resolution anchor when the ownership-checked path walker opens an absolute path on Cygwin.We treated every path beginning with
/as POSIX-absolute, opened/and removed every leading slash. This changed//server/share/pathinto/server/share/pathand caused UNC destinations to fail withENOENT. The UNC share is now opened as the trusted root. Components below the share continue through the existing ownership-checked walk. Trusted symlinks which expand to UNC paths use the same handling.