Gannet Dashboard: show SMART drive health as a readable table - #2508
Merged
Merged
Conversation
The SMART lines were joined into one paragraph of raw key=value text.
They now get their own "Drive health (SMART)" section: a pass/fail
summary, a table with plain-language columns ("not reported" in place
of "?", nonzero sector counts flagged), and a note explaining the
columns and the drives that only report pass/fail.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The SMART section of the Gannet Dashboard rendered every report line joined into one paragraph (
/dev/sda health=PASSED temp=32C realloc=0 pending=0 /dev/sdb health=PASSED temp=?C …), which was hard to read.It now has its own Drive health (SMART) section with:
?shown as a muted not reported; nonzero sector counts flagged with ⚠Parsing happens client-side from the existing
gannet_stats.smartlines, so no prober change is needed and it works with data already on theserver-statusbranch. Unparseable lines fall back to a<pre>block.Testing
Follow-up (outside this repo)
The
?values come fromgannet_health.shon gannet:sdb–sdllikely report temperature/defects under SAS-style names (e.g. "Current Drive Temperature", "grown defect list") that the script doesn't parse.🤖 Generated with Claude Code