Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Moves the build and test-compile-advanced tasks off of gulp and into node-based scripts.
Proposed Changes
scripts/gulpfiles/build_tasks.mjsscripts/build.mjsandtests/compile/test_compile_advanced.mjsADVANCED_OPTIMIZATIONS. As this is only a test and the test is passing as expected, we don't need to be concerned about this change.Reason for Changes
Removing dependency on gulp
Test Coverage
I validated these changes by doing the following:
/distfolder after gulp version of the build command and after the new node commanddevtool: isProduction ? 'source-map' : 'eval-source-map',todevtool: 'source-map')npm ci,npm run build,npm run test,npm run lint, andnpm run formatin addition to running each test script individually and running each changed script individually to ensure they work consistently and as expected.Additional Information
AI was used to build out the function that calls the google-closure-compiler to make the output identical to the old gulp output to give us high confidence in the output. It was also used to help debug some issues encountered during testing. All changes were verified by a human and thoroughly vetted against the gulp version of the output of these tasks.