chore: adopt ASAPPlanner issue 427 vocabulary - #753
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ASAPPlanner renamed its realization, schema resolution, and physical handoff vocabulary in ProjectASAP/ASAPPlanner#427. The backend must use the new public APIs when updating its Planner pin.
Before this PR
For example, summary selection called
SketchAlgorithmStrategy::with_models_and_evidenceand matchedImplementation::Sketch. Those names refer to the old Planner API.After this PR
The same selection calls
SketchAlgorithmStrategy::new_with_planning_inputs_and_evidenceand matchesRealization::Sketch. The Planner dependency is pinned to the revision containing these renames. Backend references and the planner-runtime contract link use the new vocabulary.Verification
cargo fmt --all --checkcargo test -p control_plane --lib --locked(425 passed)cargo test -p control_plane --test offline_evidence --locked(6 passed)cargo check -p data_plane --locked