build: remove local Docker dependency contexts - #745
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the sibling-checkout requirement from main's data-plane and control-plane Docker images now that ASAPCollector and asap_sketchlib are public.
Before this PR: Building either image required three named Docker build contexts pointing to local dependency checkouts.
After this PR:
docker build -f data_plane/Dockerfile -t asap/data-plane:dev .(and the equivalent control-plane command) needs only the backend checkout. Cargo fetches public Git dependencies, and--lockedpreserves the revisions in Cargo.lock.Validation:
cargo metadata --locked --format-version 1andgit diff --checkpassed. Confirmed all local Cargo dependencies stay inside the backend checkout and all pinned Git revisions are publicly accessible. Full image builds were not run because Docker is unavailable in the development environment.Related to #735. This PR intentionally covers main's two Dockerfiles only; the Compose suite and Docker-only patches on #742 remain outside its scope.