Adds draft caching mechanism - #461
indented-automation wants to merge 2 commits into
Conversation
|
So the test run... My new tests work locally when I force-load Pester 5.0.2 to ensure everything is nicely lined up. Several of the sanity tests still fail though. They're a bit incompatible with latest versions of Pester 5 right now. A few of the tests are actually acting out changes. For instance I get Would you like me to fix these things? |
|
If you have time to sort them out, please feel free 😅 I've been meaning to sort them out for a long time, but I haven't had the time/energy. 😔 |
|
These tests should be fixed. Can you rebase this PR? |
|
Yeah, I'll take a look tomorrow and see how we get on.
…On Sat, 19 Sept 2026 at 18:10, Gilbert Sanchez ***@***.***> wrote:
*HeyItsGilbert* left a comment (PowerShellOrg/PSKoans#461)
<#461 (comment)>
These tests should be fixed. Can you rebase this PR?
—
Reply to this email directly, view it on GitHub
<#461?email_source=notifications&email_token=ADB3UDQ62EZVQKCAFGGSXR35P3DX3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNZUGQZDEMJTGI4KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5744221328>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADB3UDTNDOBCPLZYNWSHTVT5P3DX3AVCNFSNUABEKJSXA33TNF2G64TZHMYTGOJYHE4TAOJUHNEXG43VMU5TSOJVHEZTOOJUGWQXMAQ>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/ADB3UDXLOYL67N5JOEGK3TD5P3DX3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNZUGQZDEMJTGI4KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/ADB3UDTUL5ASWTGJAWGGI535P3DX3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNZUGQZDEMJTGI4KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
HeyItsGilbert
left a comment
There was a problem hiding this comment.
This looks good to me. We probably just need to rebase this and make sure all the tests pass.
| function Get-KoanCachedResult { | ||
| <# | ||
| .SYNOPSIS | ||
| Add an entry to the koan cache. |
There was a problem hiding this comment.
| Add an entry to the koan cache. | |
| Read the entry for the koan cache. |
PR Summary
Fixes #457
Context
This potentially fixes issue 457 by adding a caching mechanism. When a koan is evaluated for the first time the results of that evaluation are cached (as clixml). Clixml is used to attempt to ensure that error messages are presented in the same manner as a direct run.
This update changes the execution time of Measure-Karma to a fairly static value of around 2000ms which flucuates only based on the current in-progress topic.
Cached results are stored in ~\config\PSKoans\cache.
Changes
Checklist