Repository navigation
Conversation
mvieth
reviewed
Oct 5, 2026
larshg
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6483.
ASCIIReader calculates buffer sizes using 32-bit multiplication before converting the result to std::size_t. On 64-bit systems, large inputs can therefore produce a truncated buffer size.
Promote one operand to std::size_t before multiplication in both the initial allocation and the final resize. This follows the approach approved in the issue and used by PLYReader.
Add a regression test that supplies synthetic large metadata through readHeader() and exercises the real read() method. The expected size exceeds vector::max_size(), allowing the test to check rejection without allocating a huge buffer.
Validation:
Tested on arm64 macOS with 64-bit std::size_t. This change does not add overflow checks for 32-bit systems.