Repository navigation
Conversation
mvieth
force-pushed
the
nanoflann_default6
branch
13 times, most recently
from
August 22, 2026 09:40
38806b0 to
7b8af0f
Compare
mvieth
force-pushed
the
nanoflann_default6
branch
4 times, most recently
from
August 30, 2026 09:56
fec9bac to
890c441
Compare
mvieth
force-pushed
the
nanoflann_default6
branch
from
August 30, 2026 12:15
890c441 to
733f050
Compare
mvieth
force-pushed
the
nanoflann_default6
branch
from
September 1, 2026 15:11
826408c to
ff07499
Compare
mvieth
marked this pull request as ready for review
September 24, 2026 10:42
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, it is now possible to build most of PCL without having FLANN installed (apps, examples, test, benchmarks, and some tutorials still need FLANN and the kdtree module that depends on FLANN). It is still highly recommended to have either FLANN or nanoflann installed. If both are available, PCL auto-selects
KdTreeNanoflannby default (faster thanKdTree). I have tested with only FLANN installed, with only nanoflann installed, and with neither FLANN nor nanoflann installed (all scenarios build successfully). The CIs additionally check the scenario where both FLANN and nanoflann are installed.This PR
pcl::search::autoSelectMethodwhere the PointRepresentation to be used can be specified (the other overloads use the default point representation). This overload usesKdTreeNanoflann,KdTree, orBruteForce, depending on what is available.KdTreeNanoflannto not inherit fromKdTreebut fromSearchdirectly (KdTreeis not available if FLANN is not found)pcl::search::KdTreetoautoSelectMethodin the registration and recognition modulessetPointRepresentationinpcl::search::Search(overridden in several subclasses, e.g.KdTreeandKdTreeNanoflann), and makes it return whether it was successful and the point representation will be used, or not.point_representation_given by user or not,tree_given by user or not, indices given by user or not, ...)tree_, and I think it is technically not necessary to filltree_withBruteForcethere (would otherwise be filled inFeature::initCompute ()). It only has the minor advantage thatBruteForcedoes not perform any work preparing for searching (like setting up a kdtree, which would be wasted time, since the tree is unused)