Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Shared Homa state destroyed before namespace cleanup
homa_destroy()ran beforeunregister_pernet_subsys().homa_net_exit()/homa_net_destroy(), which still require the shared Homa state.homa_destroy()after the other unregister/cleanup operations.Timetrace
/procstate left behind on load failurett_destroy(), leaving staleprocentries and causing a delayed crash when accessed.tt_destroy()in the error cleanup path, guarded by#ifndef __UPSTREAM__because timetrace is excluded from the upstream kernel tree byutil/strip.py.tt_init()failure ignoredhoma_load()did not check the result oftt_init().tt_init()fails; no downstream Homa initialization has occurred, so the general cleanup path is unnecessary.Also fixed a small bug in
homa_rpc_ack__multiple_ackswhich attempted to destroy an uninitialized socketWhy?
The above bugs, combined with missing .netns_ok caused the Homa module to fail to load + crash my RHEL 8 test box.
.netns_okis only applicable to RHEL8, however these changes are generally applicable to the module and are not exclusive to RHEL8Each bug fix addressed a different failure mode the occurred during my testing. Stacking all of these fixes allowed me to successfully load the kernel module.
Testing?
I have added unit tests covering each bug to ensure a future regression would be detected
Anything else?
These changes will need to be back-merged into
rhel8as well