Fix Workshop-only updates without a Minecraft version - #294
Closed
QIU-Guanzong wants to merge 2 commits into
Closed
QIU-Guanzong wants to merge 2 commits into
QIU-Guanzong wants to merge 2 commits into
Conversation
Builds on the inactive implementation from PR Osiris-Team#290, with Workshop consumer app-id resolution and stricter SteamCMD success handling.
Owner
|
Original base PR was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a derived, competing PR based on #291. It preserves that PR's Workshop implementation and adds a narrow regression fix for its current head:
server-updater.versionfallback before probing the server executable;The current #291 code eagerly calls
Server.getMCVersion()before it reaches its Steam Workshop branch. That makes a DayZ Workshop-only update check fail when the server executable cannot provide a Minecraft version. The new test fails against #291's current head and passes with this branch.An earlier public issue comment describes the same condition. This PR does not claim exclusive discovery; it provides a reviewable derived branch with the focused regression test for the competing-PR process.
Validation
Result: 5 tests run, 0 failures, 0 errors.
git diff --checkalso passes.The test uses synthetic files and a fake SteamCMD boundary. No live DayZ server or Steam operation was run, and no full test-suite result is claimed.
AI assistance and scope
This contribution was developed with substantial AI assistance. The automated validation above is reported exactly as run; this PR does not claim human validation. Please review the implementation and test before considering it for merge.
This PR does not claim bounty eligibility, payment, or any payment identity details.