memory leak in LAPACK iparam2stage (C code)

[mgates3]

There's a memory leak in iparam2stage here:
https://github.com/OpenMathLib/OpenBLAS/blob/develop/lapack-netlib/SRC/iparam2stage.c#L427
The string is malloced but never freed. I don't really see why there is a malloc, since subnam is already allocated on the stack in this line:
https://github.com/OpenMathLib/OpenBLAS/blob/develop/lapack-netlib/SRC/iparam2stage.c#L232
Simply deleting L427 should fix the issue.

[dasergatskov]

I can confirm this with ASAN.

$ cat repro_iparam2stage.c 
extern int iparam2stage_(int *, char *, char *, int *, int *, int *, int *);

int main(void)
{
    int ispec = 20, n = 100, nb = 32, ib = 16, nx = -1;

    iparam2stage_(&ispec, "DSYTRD_2STAGE", "N", &n, &nb, &ib, &nx);
    return 0;
}

repro_iparam2stage.c

$ clang -g -Og -fsanitize=address repro_iparam2stage.c  OpenBLAS/lapack-netlib/SRC/{iparam2stage,ilaenv,iparmq,ieeeck}.c  -lm -o repro_iparam2stage

and

$ ./repro_iparam2stage 

=================================================================
==2169547==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 7 byte(s) in 1 object(s) allocated from:
    #0 0x000000517528 in malloc (/home/dmitri/src/repro_iparam2stage+0x517528) (BuildId: 7abd9cbd65bf2c0095a260e607b8133b9fc79d1b)
    #1 0x00000055b3bb in iparam2stage_ /home/dmitri/src/OpenBLAS/lapack-netlib/SRC/iparam2stage.c:427:15
    #2 0x00000055a911 in main /home/dmitri/src/repro_iparam2stage.c:7:5
    #3 0x7fad99c08300 in __libc_start_call_main (/lib64/libc.so.6+0x7d300) (BuildId: b8ffe3012ccf739a99cc7f153e2f2031d6daec1e)
    #4 0x7fad99c08417 in __libc_start_main@GLIBC_2.2.5 (/lib64/libc.so.6+0x7d417) (BuildId: b8ffe3012ccf739a99cc7f153e2f2031d6daec1e)
    #5 0x0000004673a4 in _start (/home/dmitri/src/repro_iparam2stage+0x4673a4) (BuildId: 7abd9cbd65bf2c0095a260e607b8133b9fc79d1b)

SUMMARY: AddressSanitizer: 7 byte(s) leaked in 1 allocation(s).