Add hi3516dv100_lite_xm-n81820 device profile (MS41908M SPI lens) - #171
Conversation
New profile for the Xiongmai HI3516D_N81820 (HiSilicon Hi3516A/D V100, hi3516dv100 / family hi3516av100) with a Sony IMX291 DC sensor and a Panasonic MS41908M motorized zoom/focus lens on SPI. Modeled on hi3516ev300_lite_xm-85h50ai, but the motor is an SPI stepper (/dev/spidev1.0), driven by majestic-af's `ms41908` actuator — not a UART Pelco lens — so there is no console-UART sharing to work around. - defconfig: from hi3516dv100_lite, + BR2_PACKAGE_MAJESTIC_AF=y, FLASH_SIZE=16 (Winbond W25Q128, confirmed on the unit), and WiFi packages dropped (Ethernet-only board). - customizer: sensor imx291 pinned to the DC ini (imx291_i2c_dc_1080p.ini; the MIPI default would give no video), autofocus enabled with actuator=ms41908 (the SPI backend isn't reachable via the pelco-only ptz_control env, so it is set directly in majestic config). - excludes: keep libsns_imx291_dc.so + imx291_i2c_dc_1080p.ini, strip the other hi3516av100-osdrv sensors. Needs the companion firmware majestic-af bump (OpenIPC/firmware#2485) so the packaged plugin carries the ms41908 backend, and a majestic rebuild carrying the isp.autofocus.actuator=ms41908 enum (majestic#905, merged).
PR Summary by QodoAdd XiongMai N81820 profile with MS41908M SPI autofocus
AI Description
Diagram
High-Level Assessment
Files changed (4)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can type 'qodo, fix this' on a finding and the fix lands right on your PR |
New profile for the Xiongmai HI3516D_N81820 (HiSilicon Hi3516A/D V100,
hi3516dv100/ familyhi3516av100) — Sony IMX291 DC sensor, 16 MB NOR(W25Q128), Ethernet-only — with a Panasonic MS41908M motorized zoom/focus
lens. Modeled on the proven
hi3516ev300_lite_xm-85h50ai, but the motor is anSPI stepper (
/dev/spidev1.0), driven by majestic-af'sms41908actuator —not a UART Pelco lens — so there's no console-UART sharing to work around. All
facts confirmed on the live board (devid 00014914).
Files
hi3516dv100_lite, plusBR2_PACKAGE_MAJESTIC_AF=y,BR2_OPENIPC_FLASH_SIZE="16", and the WiFi packages dropped (wired board).sensor imx291pinned to the DC ini(
imx291_i2c_dc_1080p.ini; the MIPI default would give no video); autofocusenabled with
actuator=ms41908(the SPI backend isn't reachable via thepelco-only
ptz_controlenv, so it's set directly in majestic config).libsns_imx291_dc.so+ the DC ini, strip the otherhi3516av100-osdrv sensors.
ci-matrix.py --self-testpasses (device registered).Dependency chain (for motors to work OOTB)
ms41908to theisp.autofocus.actuatorenum) — merged.majestic-afpackage to the ms41908 backend) —merged, so this device's image links the SPI-capable plugin.
majestic.hi3516av100.*S3 binary must be rebuilt by the OpenIPCnightly to pick up the #905 enum before
actuator=ms41908validates on-device;/dev/spidev1.0is present OOTB and the majestic binary already has the pluginloader. Final on-hardware flash/verify pending on the board.